This repository has been archived by the owner on Feb 19, 2023. It is now read-only.
Update dependencies #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, thank you so much! Yeah, ranges are always a pain point, best of luck figuring them out. <3 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be required in order to be able to support latest features of LSP (like labelDetails)
It's not ready to get merged because there is a bug in ZLS
Removing this field fixes the issue: https://github.com/zigtools/zls/blob/fc5b1c64579e0ec33ea374051bcfef59ebfc0c5c/src/types.zig#L245
Something about ranges is wrong, i tried to investigate today, but i couldn't find the cause, so i just commented that line.. so far it seems to be ok
I'll try to spend more time on it tomorrow, since i need that to get sorted out to be able to send a PR to add labelDetails support