Broken cross-file references

[SuperAuguste]

references.zig uses DocumentStore.collectDependencies which collects the imports a file specifies; this incorrect - we should be collecting dependents (files that import the current file), not dependencies (files that the current file imports).

To take this on you'd have to create a new collectDependents function that loads in all files in a workspace while checking for imports and returns all files that import the current file.

[Jarred-Sumner]

Yes I think this is what I meant with this issue: #1070

After a recent change, an import 3-4 levels deep through usingnamespace stops working

https://github.com/oven-sh/bun/blob/6f59bc7d2e7aa64956bdd6f56769467853fd0242/src/main.zig#L45

[Techatrix]

To make it clear what this issue means it practice, here is a symbol references test that is currently failing:

zls/tests/lsp_features/references.zig

Lines 208 to 216 in fedbf31

	test "cross-file reference" {
	if (true) return error.SkipZigTest; // TODO
	try testMFReferences(&.{
	\\pub const <0> = struct {};
	,
	\\const file = @import("file_0.zig");
	\\const F = file.<0>;
	});
	}

The first file declaretes a public struct and the second file tries to import and use it. Asking for symbol references on the struct declaration in the first file will not find the reference in the second file.

[Argmaster]

Hi, I am not sure if this belongs here, I couldn't find issue description that would fit my case exactly, but this one sounds a bit like it, so here is the deal:

In project, ZLS has no idea what const main = @import("root") means, gives no suggestions, can not resolve the "root" when I try to go to definition. As a result any symbol referenced through main variable become completely opaque. It makes navigating files grouped in folders really troublesome :C

Found in project called Cubyz.

Is that duplicate of this issue?
Are there any workarounds for this?

[RoadRoller01]

Wouldn't it be better to first search for the symbol in all files within a workspace, and then process only those files if they are really referencing the symbol.

[RoadRoller01]

And I it could also be better if the symbol accorded in a file you immediately check if its really referencing it, Instead of collecting an array list then process it.

[ANtlord]

Could it be a "good first issue"?