Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add completions_with_replace flag #1458

Merged
merged 1 commit into from
Oct 1, 2023
Merged

Add completions_with_replace flag #1458

merged 1 commit into from
Oct 1, 2023

Conversation

almmiko
Copy link
Contributor

@almmiko almmiko commented Sep 23, 2023

Adds completions_with_replace flag to determine replace behavior.

Fixes: #1235

SuperAuguste
SuperAuguste approved these changes Oct 1, 2023
View reviewed changes
Copy link
Member

@SuperAuguste SuperAuguste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this as this is a good compromise, but in the future, we'd like to review how we do completion replacement in a manner acceptable for all so a flag like this may not be necessary.

@SuperAuguste SuperAuguste merged commit de2464a into zigtools:master Oct 1, 2023
3 checks passed
KoltPenny pushed a commit to KoltPenny/zls that referenced this pull request Oct 18, 2023
@almmiko @KoltPenny
add completions_with_replace flag (zigtools#1458)
7150072
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperAuguste SuperAuguste SuperAuguste approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zig confirm suggestion "replace" instead of "insert"
2 participants
@almmiko @SuperAuguste