Refactor enum_literal compls #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llogick
force-pushed
the
nullptrdevs/refactor-enum_literal_compls
branch
from
7f30056 to
4b52065
Compare
llogick
force-pushed
the
nullptrdevs/refactor-enum_literal_compls
branch
from
4b52065 to
cdf237a
Compare
Techatrix
requested changes
Oct 9, 2023
There was a problem hiding this comment.
I did not perform any more checks on my suggestions than running tests so they may break something.
The only exception is the suggestion about the @import builtin resolution since the current testing infrastructure doesn't support multi file completion tests.
Could you also please remove your debugging related print statements including those that you have comment out.
llogick
force-pushed
the
nullptrdevs/refactor-enum_literal_compls
branch
from
cdf237a to
55eb9e8
Compare
|
Applied all of the above, multi file completions seem to work. |
Techatrix
requested changes
Oct 10, 2023
Co-authored-by: Techarix <19954306+Techatrix@users.noreply.github.com>
llogick
force-pushed
the
nullptrdevs/refactor-enum_literal_compls
branch
from
55eb9e8 to
102f1af
Compare
|
Ditto |
|
LGTM, hopefully nothing has regressed through these changes. |
Techatrix
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not perfect, but functional .