config error reporting

README.md

@@ -68,9 +68,6 @@ The following options are currently available.
 | `dangerous_comptime_experiments_do_not_enable` | `bool` | `false` | Whether to use the comptime interpreter |
 | `skip_std_references` | `bool` | `false` | When true, skips searching for references in std. Improves lookup speed for functions in user's code. Renaming and go-to-definition will continue to work as is |
 | `prefer_ast_check_as_child_process` | `bool` | `true` | Favor using `zig ast-check` instead of ZLS's fork |
-| `record_session` | `bool` | `false` | When true, zls will record all request is receives and write in into `record_session_path`, so that they can replayed with `zls replay` |
-| `record_session_path` | `?[]const u8` | `null` | Output file path when `record_session` is set. The recommended file extension *.zlsreplay |
-| `replay_session_path` | `?[]const u8` | `null` | Used when calling `zls replay` for specifying the replay file. If no extra argument is given `record_session_path` is used as the default path. |
 | `builtin_path` | `?[]const u8` | `null` | Path to 'builtin;' useful for debugging, automatically set if let null |
 | `zig_lib_path` | `?[]const u8` | `null` | Zig library path, e.g. `/path/to/zig/lib/zig`, used to analyze std library imports |
 | `zig_exe_path` | `?[]const u8` | `null` | Zig executable path, e.g. `/path/to/zig/zig`, used to run the custom build runner. If `null`, zig is looked up in `PATH`. Will be used to infer the zig standard library path if none is provided |

build.zig

@@ -10,7 +10,7 @@ const min_zig_string = "0.12.0-dev.3071+6f7354a04";
 const Build = blk: {
     const current_zig = builtin.zig_version;
     const min_zig = std.SemanticVersion.parse(min_zig_string) catch unreachable;
-    const is_current_zig_tagged_release = current_zig.pre == null;
+    const is_current_zig_tagged_release = current_zig.pre == null and current_zig.build == null;
     if (current_zig.order(min_zig) == .lt) {
         const message = std.fmt.comptimePrint(
             \\Your Zig version does not meet the minimum build requirement:
@@ -20,6 +20,7 @@ const Build = blk: {
             \\
         ++ if (is_current_zig_tagged_release)
             \\Please download or compile a tagged release of ZLS.
+            \\  -> https://github.com/zigtools/zls/releases
             \\  -> https://github.com/zigtools/zls/releases/tag/{[current_version]}
         else
             \\You can take one of the following actions to resolve this issue:
@@ -344,3 +345,10 @@ fn getTracyModule(
 
     return tracy_module;
 }
+
+comptime {
+    const min_zig = std.SemanticVersion.parse(min_zig_string) catch unreachable;
+    const min_zig_simple = std.SemanticVersion{ .major = min_zig.major, .minor = min_zig.minor, .patch = 0 };
+    const zls_version_simple = std.SemanticVersion{ .major = zls_version.major, .minor = zls_version.minor, .patch = 0 };
+    std.debug.assert(zls_version_simple.order(min_zig_simple) == .eq);
+}

schema.json

@@ -104,21 +104,6 @@
             "type": "boolean",
             "default": true
         },
-        "record_session": {
-            "description": "When true, zls will record all request is receives and write in into `record_session_path`, so that they can replayed with `zls replay`",
-            "type": "boolean",
-            "default": false
-        },
-        "record_session_path": {
-            "description": "Output file path when `record_session` is set. The recommended file extension *.zlsreplay",
-            "type": "string",
-            "default": null
-        },
-        "replay_session_path": {
-            "description": "Used when calling `zls replay` for specifying the replay file. If no extra argument is given `record_session_path` is used as the default path.",
-            "type": "string",
-            "default": null
-        },
         "builtin_path": {
             "description": "Path to 'builtin;' useful for debugging, automatically set if let null",
             "type": "string",

src/Config.zig

@@ -65,15 +65,6 @@ skip_std_references: bool = false,
 /// Favor using `zig ast-check` instead of ZLS's fork
 prefer_ast_check_as_child_process: bool = true,
 
-/// When true, zls will record all request is receives and write in into `record_session_path`, so that they can replayed with `zls replay`
-record_session: bool = false,
-
-/// Output file path when `record_session` is set. The recommended file extension *.zlsreplay
-record_session_path: ?[]const u8 = null,
-
-/// Used when calling `zls replay` for specifying the replay file. If no extra argument is given `record_session_path` is used as the default path.
-replay_session_path: ?[]const u8 = null,
-
 /// Path to 'builtin;' useful for debugging, automatically set if let null
 builtin_path: ?[]const u8 = null,
 

src/DocumentStore.zig

@@ -9,7 +9,6 @@ const BuildAssociatedConfig = @import("BuildAssociatedConfig.zig");
 const BuildConfig = @import("build_runner/BuildConfig.zig");
 const tracy = @import("tracy");
 const Config = @import("Config.zig");
-const ZigVersionWrapper = @import("ZigVersionWrapper.zig");
 const translate_c = @import("translate_c.zig");
 const ComptimeInterpreter = @import("ComptimeInterpreter.zig");
 const AstGen = std.zig.AstGen;
@@ -599,8 +598,6 @@ pub const ErrorMessage = struct {
 allocator: std.mem.Allocator,
 /// the DocumentStore assumes that `config` is not modified while calling one of its functions.
 config: *const Config,
-/// the DocumentStore assumes that `runtime_zig_version` is not modified while calling one of its functions.
-runtime_zig_version: *const ?ZigVersionWrapper,
 lock: std.Thread.RwLock = .{},
 thread_pool: if (builtin.single_threaded) void else *std.Thread.Pool,
 handles: std.StringArrayHashMapUnmanaged(*Handle) = .{},
@@ -772,8 +769,7 @@ pub fn refreshDocument(self: *DocumentStore, uri: Uri, new_text: [:0]const u8) !
 /// Invalidates a build files.
 /// **Thread safe** takes a shared lock
 pub fn invalidateBuildFile(self: *DocumentStore, build_file_uri: Uri) error{OutOfMemory}!void {
-    std.debug.assert(std.process.can_spawn);
-    if (!std.process.can_spawn) return;
+    comptime std.debug.assert(std.process.can_spawn);
 
     if (self.config.zig_exe_path == null) return;
     if (self.config.build_runner_path == null) return;