add type function symbols to document symbol outline #448
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ZLS skips Type Functions when enumerating the document symbols. This leads to a lot of standard library files looking like this in the VSCode Document Outline:
With the PR, it looks like:
Go To Document Symbol also works:
Change
Recurse into functions if they are a type function
Questions
I'm not too familiar with VSCode extensions or the ZLS codebase. I ran the tests and did some sanity manual testing but please review accordingly
getDocumentSymbolsInternal
: from looking at the code + cross referencing VSCode Api, looks like its just used to enumerate document symbols (call tree:documentSymbol()->getDocumentSymbols()->getDocumentSymbolsInternal()
)getDocumentSymbolsInternal
is invokedso there might be superflous guards/checks