Implement textDocument/documentHighlight #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, sorry for the late response period! May you please fix these merge conflicts and I'll get this merged ASAP! Thanks :) |
gpanders
force-pushed
the
documentHighlight
branch
from
7b69abb to
b71a83b
Compare
|
Done, thanks. |
|
LGTM despite the odd CI failure! Btw I think #554 will ease the implementation of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to implement the
textDocument/documentHighlightresponse.documentHighlightis essentially the same astextDocument/referenceswith the only differences being:DocumentHighlightKindFor now I've hardcoded the
kindto simplyText, but a more sophisticated implementation would correctly set the kind toReadorWritewhere appropriate. I will look into doing this, but help is appreciated.In my limited testing this seems to mostly work, but there are still some bugs I need to chase down. I wanted to go ahead and open this PR though to get some early feedback on the approach.