Add flake support #549
Merged
Add flake support #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Have to use it with `nix run '.?submodules=1'`, unfortunately.
Might be able to remove that requirement by using the following, but I
don't know how it interacts with `gitignoreSource`:
```
fetchGit {
url = ./.;
submodules = true;
}
```
This allows the flake to work without passing in `?submodules=1`, which makes it easy to include in other flakes. This commit also makes it possible to override the path to the `known-folders` package like so: ``` zig build -Dknown-folders=/path/to/known-folders.zig ``` This allows `flake.nix` to pass in the nix store path.
Simpler than using `fetchFromGitHub`, we can have `nix` manage the version instead
|
LGTM, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will add
flake.nix,flake.lock, and a build option-Dknown-folders=<path>to override the path to theknown-folderspackage.Will allow zls to be run like so:
Or used in another flake: