Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Latest Zig #70

Closed
wants to merge 1 commit into from
Closed

Update to Latest Zig #70

wants to merge 1 commit into from

Conversation

jcalabro
Copy link

@jcalabro jcalabro commented Jan 20, 2024

Hi there! I track master zig in a bunch of my projects, and there have been a few changes since master on zap.

A more thorough outline of those changes is here, but specifically the changes that needed to be made in this project are:

  • var -> const as it's now a compile-time requirement for data that's not mutated
  • Upgrading`build.zig to latest constructs
  • Adding the paths field to build.zig.zon

Note: I converted to a draft b/c I only tested with one example. Doing the rest now

@jcalabro jcalabro marked this pull request as draft January 20, 2024 04:03
@jcalabro
Copy link
Author

Oops, missed the note in the README about the 0.12.0 branch. Will close, but if you need any help with those changes, feel free to use, or ping me and I can make the changes over there. Sorry for the noise!

@jcalabro jcalabro closed this Jan 20, 2024
@renerocksai
Copy link
Member

Hi there and thanks for all the work in this PR. Have you checked the readme? Zap is intentionally made for the current stable release of zig (0.11). That's a feature.

However, since many users seem to prefer to use zig master, there is a zig-0.12.0 branch for zap.

@jcalabro
Copy link
Author

Hah, jinx! Thanks, sorry again!

@renerocksai
Copy link
Member

No worries and many thanks for the offer 👍!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants