Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for MemoryDB client #339

Merged
merged 7 commits into from
Jul 31, 2024
Merged

Conversation

baswanth09
Copy link
Contributor

@baswanth09 baswanth09 commented Jul 2, 2024

Draft of a MemoryDB client.
The vector search for MemoryDB was announced back in Dec 2023. As we are approaching our GA release, would like get initial feedback.

Co-authored-by:
Hassaan Khan hqkhan@users.noreply.github.com
Tyler House tahouse@users.noreply.github.com

@baswanth09
Copy link
Contributor Author

/assign @XuanYang-cn

@alwayslove2013
Copy link
Collaborator

@baswanth09 Thank you so much for your wonderful contribution to our open-source vectordb benchmark tool. We really appreciate your treasured efforts in adding a new client to evaluate MemoryDB, it will help us continue to build a high-quality, open-source testing tool.

Once the review is complete, we will provide you with feedback and work with you to get your changes merged into the main codebase.

vectordb_bench/backend/clients/memorydb/cli.py Outdated Show resolved Hide resolved
vectordb_bench/backend/clients/memorydb/cli.py Outdated Show resolved Hide resolved
vectordb_bench/backend/clients/memorydb/memorydb.py Outdated Show resolved Hide resolved
vectordb_bench/backend/clients/memorydb/memorydb.py Outdated Show resolved Hide resolved
vectordb_bench/backend/clients/memorydb/memorydb.py Outdated Show resolved Hide resolved
Co-authored-by: Jonathan S. Katz <jkatz@users.noreply.github.com>
@baswanth09 baswanth09 force-pushed the memorymind branch 2 times, most recently from 599b8e1 to c3083cc Compare July 9, 2024 20:41
Co-authored-by: Jonathan S. Katz <jkatz@users.noreply.github.com>
@alwayslove2013
Copy link
Collaborator

@baswanth09 a small conflict within readme needs to be resolved.

@alwayslove2013
Copy link
Collaborator

@jkatz I would like to express my sincere gratitude for your thorough review. Your feedback has been invaluable. If there are no further concerns, I would greatly appreciate if you could please apply an "approve" label. This would allow us to merge the pull request into the master branch.

@jkatz
Copy link
Contributor

jkatz commented Jul 18, 2024

@alwayslove2013 Thank you, and thank you for taking the time to review the PR. I have approved this.

@alwayslove2013
Copy link
Collaborator

@baswanth09 I see this PR is still in the draft stage. Once you've finished, I'd be happy to come in and take care of the merge.

As it stands, it looks like the only way to test it is through the CLI. But if you need any help with the Frontend support, I'd be glad to lend a hand.

@baswanth09 baswanth09 changed the title [Draft PR] Support for MemoryDB client Support for MemoryDB client Jul 26, 2024
@baswanth09
Copy link
Contributor Author

@alwayslove2013. Apologies for the delay. The merge conflicts are resolved now.

@alwayslove2013 alwayslove2013 enabled auto-merge (rebase) July 30, 2024 01:37
@alwayslove2013
Copy link
Collaborator

@baswanth09 We really appreciate your effort and time in helping to improve VectorDBBench. Your input is valuable and will help us make the project even better.

Looking forward to working with you further!

auto-merge was automatically disabled July 30, 2024 01:42

Rebase failed

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alwayslove2013, baswanth09, jkatz
To complete the pull request process, please assign xuanyang-cn after the PR has been reviewed.
You can assign the PR to them by writing /assign @xuanyang-cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alwayslove2013
Copy link
Collaborator

@baswanth09 It appears there are still some lingering conflicts here that may need to be addressed.

@baswanth09
Copy link
Contributor Author

baswanth09 commented Jul 30, 2024

@alwayslove2013 I fetched the latest upstream changes and merged into my local branch, didn't encountered any merge conflicts. Let me know if I am missing something here.

@alwayslove2013 alwayslove2013 merged commit e546a42 into zilliztech:main Jul 31, 2024
@baswanth09 baswanth09 deleted the memorymind branch July 31, 2024 14:47
alwayslove2013 pushed a commit to alwayslove2013/VectorDBBench that referenced this pull request Aug 7, 2024
* Add support for MemoryDB

* Add support for MemoryDB

* Update vectordb_bench/backend/clients/memorydb/cli.py

Co-authored-by: Jonathan S. Katz <jkatz@users.noreply.github.com>

* Update vectordb_bench/backend/clients/memorydb/cli.py

Co-authored-by: Jonathan S. Katz <jkatz@users.noreply.github.com>

---------

Co-authored-by: Baswanth Vegunta <baswanth@amazon.com>
Co-authored-by: Jonathan S. Katz <jkatz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants