-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for MemoryDB client #339
Conversation
/assign @XuanYang-cn |
@baswanth09 Thank you so much for your wonderful contribution to our open-source vectordb benchmark tool. We really appreciate your treasured efforts in adding a new client to evaluate Once the review is complete, we will provide you with feedback and work with you to get your changes merged into the main codebase. |
Co-authored-by: Jonathan S. Katz <jkatz@users.noreply.github.com>
599b8e1
to
c3083cc
Compare
Co-authored-by: Jonathan S. Katz <jkatz@users.noreply.github.com>
@baswanth09 a small conflict within |
@jkatz I would like to express my sincere gratitude for your thorough review. Your feedback has been invaluable. If there are no further concerns, I would greatly appreciate if you could please apply an "approve" label. This would allow us to merge the pull request into the master branch. |
@alwayslove2013 Thank you, and thank you for taking the time to review the PR. I have approved this. |
@baswanth09 I see this PR is still in the draft stage. Once you've finished, I'd be happy to come in and take care of the merge. As it stands, it looks like the only way to test it is through the |
@alwayslove2013. Apologies for the delay. The merge conflicts are resolved now. |
@baswanth09 We really appreciate your effort and time in helping to improve Looking forward to working with you further! |
Rebase failed
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alwayslove2013, baswanth09, jkatz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@baswanth09 It appears there are still some lingering conflicts here that may need to be addressed. |
@alwayslove2013 I fetched the latest upstream changes and merged into my local branch, didn't encountered any merge conflicts. Let me know if I am missing something here. |
* Add support for MemoryDB * Add support for MemoryDB * Update vectordb_bench/backend/clients/memorydb/cli.py Co-authored-by: Jonathan S. Katz <jkatz@users.noreply.github.com> * Update vectordb_bench/backend/clients/memorydb/cli.py Co-authored-by: Jonathan S. Katz <jkatz@users.noreply.github.com> --------- Co-authored-by: Baswanth Vegunta <baswanth@amazon.com> Co-authored-by: Jonathan S. Katz <jkatz@users.noreply.github.com>
Draft of a MemoryDB client.
The vector search for MemoryDB was announced back in Dec 2023. As we are approaching our GA release, would like get initial feedback.
Co-authored-by:
Hassaan Khan hqkhan@users.noreply.github.com
Tyler House tahouse@users.noreply.github.com