Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add client aws_opensearch #342

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Add client aws_opensearch #342

merged 1 commit into from
Jul 18, 2024

Conversation

cydrain
Copy link
Contributor

@cydrain cydrain commented Jul 15, 2024

No description provided.

XuanYang-cn
XuanYang-cn requested changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add opensearch related info in README.md and the python package in pyproject.toml

@cydrain cydrain force-pushed the caiyd_support_aws_opensearch branch 5 times, most recently from a9d25e3 to b3991cb Compare July 18, 2024 03:14
@cydrain
Add client aws_opensearch
5dff599 
Signed-off-by: Cai Yudong <yudong.cai@zilliz.com>
@cydrain cydrain force-pushed the caiyd_support_aws_opensearch branch from b3991cb to 5dff599 Compare July 18, 2024 03:32
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cydrain, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@XuanYang-cn XuanYang-cn merged commit c45876c into zilliztech:main Jul 18, 2024
4 checks passed
@cydrain cydrain deleted the caiyd_support_aws_opensearch branch July 18, 2024 06:36
@navneet1v
Copy link
Contributor

navneet1v commented Jul 18, 2024 •
edited
Loading

@XuanYang-cn this PR lacks optimal settings for AWS Opensearch to give best performance. What is the best way to add those improvements here?

Ref: https://opensearch.org/docs/latest/search-plugins/knn/performance-tuning/

@xiaofan-luan
Copy link
Collaborator

@navneet1v
feel free to optimize and submit another request.
We are not expert on optimizing opensearch.

Or you can give some critical optimization?
I'm not sure Disable the refresh interval and disable replica will a an option in production.

@liliu-z
Copy link
Collaborator

liliu-z commented Jul 22, 2024 •
edited
Loading

@alwayslove2013 let's take a closer look at this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuanYang-cn XuanYang-cn XuanYang-cn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cydrain @sre-ci-robot @navneet1v @xiaofan-luan @liliu-z @XuanYang-cn