support auto name generation (#196)

core/backup_context_test.go

@@ -3,14 +3,15 @@ package core
 import (
 	"context"
 	"fmt"
+	"math/rand"
+	"testing"
+
 	"github.com/stretchr/testify/assert"
 	"github.com/zilliztech/milvus-backup/core/paramtable"
 	"github.com/zilliztech/milvus-backup/core/proto/backuppb"
 	"github.com/zilliztech/milvus-backup/core/utils"
 	"github.com/zilliztech/milvus-backup/internal/log"
 	"go.uber.org/zap"
-	"math/rand"
-	"testing"
 )
 
 func TestCreateBackup(t *testing.T) {
@@ -84,6 +85,26 @@ func TestDeleteBackup(t *testing.T) {
 
 }
 
+func TestCreateBackupWithNoName(t *testing.T) {
+	var params paramtable.BackupParams
+	params.Init()
+	context := context.Background()
+	backup := CreateBackupContext(context, params)
+
+	randBackupName := ""
+
+	req := &backuppb.CreateBackupRequest{
+		BackupName: randBackupName,
+	}
+	resp := backup.CreateBackup(context, req)
+	assert.Equal(t, backuppb.ResponseCode_Success, resp.GetCode())
+
+	// clean
+	backup.DeleteBackup(context, &backuppb.DeleteBackupRequest{
+		BackupName: randBackupName,
+	})
+}
+
 func TestCreateBackupWithUnexistCollection(t *testing.T) {
 	var params paramtable.BackupParams
 	params.Init()

core/backup_impl_create_backup.go

@@ -43,6 +43,9 @@ func (b *BackupContext) CreateBackup(ctx context.Context, request *backuppb.Crea
 	}
 
 	// backup name validate
+	if request.GetBackupName() == "" {
+		request.BackupName = "backup_" + fmt.Sprint(time.Now().UTC().Format("2006_01_02_15_04_05_")) + fmt.Sprint(time.Now().Nanosecond())
+	}
 	if request.GetBackupName() != "" {
 		exist, err := b.getStorageClient().Exist(b.ctx, b.backupBucketName, b.backupRootPath+SEPERATOR+request.GetBackupName())
 		if err != nil {
@@ -68,12 +71,7 @@ func (b *BackupContext) CreateBackup(ctx context.Context, request *backuppb.Crea
 		return resp
 	}
 
-	var name string
-	if request.GetBackupName() == "" {
-		name = "backup_" + fmt.Sprint(time.Now().Unix())
-	} else {
-		name = request.BackupName
-	}
+	var name string = request.BackupName
 
 	milvusVersion, err := b.getMilvusClient().GetVersion(b.ctx)
 	if err != nil {