[FIX]: Empty b.params.MinioCfg.RootPath handler (S3/Ceph) #177
Conversation
|
Welcome @punkerpunker! It looks like this is your first PR to zilliztech/milvus-backup 🎉 |
|
@punkerpunker Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/main/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
|
@punkerpunker Please associate the related issue to the body of your Pull Request. (eg. “issue: #”) |
Signed-off-by: Gleb Vazhenin <gleb.vazhenin@team.bumble.com>
punkerpunker
force-pushed
the
fix_empty_root_path_handler
branch
from
cace56e to
759a600
Compare
punkerpunker
changed the title
|
@punkerpunker Hi, there is |
Signed-off-by: Gleb Vazhenin <gleb.vazhenin@team.bumble.com>
|
Added @wayblink, thanks! |
punkerpunker
changed the title
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: punkerpunker, wayblink The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* [FIX]: Empty b.params.MinioCfg.RootPath hadler Signed-off-by: Gleb Vazhenin <gleb.vazhenin@team.bumble.com>
…#177) * [FIX]: Empty b.params.MinioCfg.RootPath hadler Signed-off-by: Gleb Vazhenin <gleb.vazhenin@team.bumble.com>
Intended to fix #176
I tested it on my side, that seems to help. Just adding a simple handler for the cases where
b.params.MinioCfg.RootPathis empty. Thanks!