Improve some metric

Signed-off-by: SimFG <bang.fu@zilliz.com>
zilliztech · Nov 23, 2023 · 9ca2777 · 9ca2777
1 parent e346111
commit 9ca2777
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/core/reader/replicate_channel_manager.go b/core/reader/replicate_channel_manager.go
@@ -676,9 +676,6 @@ func (r *replicateChannelHandler) handlePack(pack *msgstream.MsgPack) *msgstream
 	for _, position := range newPack.EndPositions {
 		position.ChannelName = pChannel
 	}
-	if r.msgPackCallback != nil {
-		r.msgPackCallback(r.pChannelName, newPack)
-	}
 	needTsMsg = needTsMsg || len(newPack.Msgs) == 0
 	if needTsMsg {
 		timeTickResult := msgpb.TimeTickMsg{
@@ -699,6 +696,9 @@ func (r *replicateChannelHandler) handlePack(pack *msgstream.MsgPack) *msgstream
 		}
 		newPack.Msgs = append(newPack.Msgs, timeTickMsg)
 	}
+	if r.msgPackCallback != nil {
+		r.msgPackCallback(r.pChannelName, newPack)
+	}
 	return newPack
 }
 

diff --git a/server/cdc_impl.go b/server/cdc_impl.go
@@ -645,6 +645,7 @@ func (e *MetaCDC) startReplicateDMLMsg(replicateCtx context.Context, info *meta.
 				var metaOpPosition *meta.PositionInfo
 				if msgPack.Msgs != nil && len(msgPack.Msgs) > 0 && msgPack.Msgs[0].Type() != commonpb.MsgType_TimeTick {
 					metaOpPosition = metaPosition
+					metrics.APIExecuteCountVec.WithLabelValues(info.TaskID, "ReplicateMessage").Inc()
 				}
 				metaTargetPosition := &meta.PositionInfo{
 					Time: msgTime,