Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip the op msg when the entity has been drop #39

Merged
merged 14 commits into from
Jan 12, 2024
Merged

Conversation

SimFG
Copy link
Collaborator

@SimFG SimFG commented Dec 28, 2023

issue: #36

@SimFG SimFG force-pushed the main branch 2 times, most recently from 022efad to 6f5e0c5 Compare December 28, 2023 13:09
Signed-off-by: SimFG <bang.fu@zilliz.com>
Signed-off-by: SimFG <bang.fu@zilliz.com>
SimFG added 3 commits January 2, 2024 15:56
Signed-off-by: SimFG <bang.fu@zilliz.com>
Signed-off-by: SimFG <bang.fu@zilliz.com>
Signed-off-by: SimFG <bang.fu@zilliz.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2024

Codecov Report

Attention: 519 lines in your changes are missing coverage. Please review.

Comparison is base (5e2ce2e) 81.59% compared to head (44a2ce9) 74.64%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
- Coverage   81.59%   74.64%   -6.95%     
==========================================
  Files          38       39       +1     
  Lines        4096     4852     +756     
==========================================
+ Hits         3342     3622     +280     
- Misses        626     1043     +417     
- Partials      128      187      +59     
Files Coverage Δ
core/reader/channel_reader.go 96.73% <100.00%> (ø)
core/reader/collection_reader.go 81.48% <100.00%> (+1.97%) ⬆️
server/metrics/metrics.go 76.92% <100.00%> (+1.92%) ⬆️
server/writer_callback.go 100.00% <100.00%> (ø)
core/api/data_handler.go 84.21% <0.00%> (-4.68%) ⬇️
core/api/meta_op.go 87.50% <0.00%> (-12.50%) ⬇️
server/server.go 78.57% <0.00%> (-1.92%) ⬇️
core/util/atomic.go 91.30% <60.00%> (-5.31%) ⬇️
core/util/retry_option.go 59.09% <50.00%> (-40.91%) ⬇️
core/writer/milvus_handler.go 92.53% <75.00%> (-5.11%) ⬇️
... and 6 more

Signed-off-by: SimFG <bang.fu@zilliz.com>
Signed-off-by: SimFG <bang.fu@zilliz.com>
SimFG added 3 commits January 3, 2024 15:05
Signed-off-by: SimFG <bang.fu@zilliz.com>
Signed-off-by: SimFG <bang.fu@zilliz.com>
Signed-off-by: SimFG <bang.fu@zilliz.com>
@SimFG SimFG force-pushed the main branch 3 times, most recently from db6d8ee to bcfe83f Compare January 4, 2024 09:13
Signed-off-by: SimFG <bang.fu@zilliz.com>
SimFG added 2 commits January 5, 2024 17:23
Signed-off-by: SimFG <bang.fu@zilliz.com>
Signed-off-by: SimFG <bang.fu@zilliz.com>
@SimFG SimFG force-pushed the main branch 6 times, most recently from c96f3ca to d059394 Compare January 12, 2024 12:01
Signed-off-by: SimFG <bang.fu@zilliz.com>
@SimFG SimFG merged commit 2750b22 into zilliztech:main Jan 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants