Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Add resources configuration to initcontainers #60

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aigptteam
Copy link

What this PR does / why we need it:

Allow to deploy that chart on Kube clusters which force to have resources configuration for every pods (even initContainers)

Checklist

  • Add ressources to other components
  • Update values
  • Update doc

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aigptteam
To complete the pull request process, please assign zwd1208 after the PR has been reviewed.
You can assign the PR to them by writing /assign @zwd1208 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot
Copy link
Collaborator

Welcome @aigptteam! It looks like this is your first PR to zilliztech/milvus-helm 🎉

@haorenfsa
Copy link
Collaborator

@aigptteam Hi, thank you for providing this patch, please make sure that the sign-off is added before we cloud merge it.

check this link for detail https://github.com/zilliztech/milvus-helm/pull/60/checks?check_run_id=21731562172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants