Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor spelling/grammar change #18

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Minor spelling/grammar change #18

merged 1 commit into from
Oct 11, 2022

Conversation

evantkchong
Copy link

Just a minor change of Paremeter -> Parameter as well as it's phrasing.


Would also like to suggest that certain error messages can be improved somewhat.

An example would be, if incorrectly specifying the schema-field when creating a collection, we explicitly state that the format for should be <fieldName>:<dataType>:<dimOfVector/desc> like so:

milvus_cli > create collection -c book -f book_id:INT64 -f word_count:INT64 -f book_intro:FLOAT_VECTOR:2 -p book_id
Error!
Field schema should be in the `<fieldName>:<dataType>:<dimOfVector/desc>` format.

instead of

milvus_cli > create collection -c book -f book_id:INT64 -f word_count:INT64 -f book_intro:FLOAT_VECTOR:2 -p book_id
Error!
Field should contain three parameters and concat by ":".

Or at least refer users to the Milvus_CLI Command Reference for any "syntax errors"

Paremeter -> Parameter
@evantkchong
Copy link
Author

Hey @shanghaikid, could you take a look?

@shanghaikid shanghaikid merged commit 7b0d814 into zilliztech:main Oct 11, 2022
@evantkchong evantkchong deleted the patch-1 branch October 12, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants