fix: call onBeforeChange and onAfterChange lifecycle methods when…

… clicking track Fixes #180
zillow · Jun 15, 2020 · e2f9473 · e2f9473
1 parent 3f30cec
commit e2f9473
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/src/components/ReactSlider/ReactSlider.jsx b/src/components/ReactSlider/ReactSlider.jsx
@@ -457,12 +457,10 @@ class ReactSlider extends React.Component {
         if (this.props.disabled || e.button === 2) {
             return;
         }
-        this.hasMoved = false;
         if (!this.props.snapDragDisabled) {
             const position = this.getMousePosition(e);
             this.forceValueFromPosition(position[0], i => {
                 this.start(i, position[0]);
-                this.fireChangeEvent('onChange');
                 addHandlers(this.getMouseEventMap());
             });
         }
@@ -691,7 +689,12 @@ class ReactSlider extends React.Component {
             }
         }
 
-        this.setState({ value }, callback.bind(this, closestIndex));
+        this.fireChangeEvent('onBeforeChange');
+        this.hasMoved = true;
+        this.setState({ value }, () => {
+            callback(closestIndex);
+            this.fireChangeEvent('onChange');
+        });
     }
 
     // clear all pending timeouts to avoid error messages after unmounting
@@ -709,8 +712,6 @@ class ReactSlider extends React.Component {
             thumbRef.focus();
         }
 
-        this.hasMoved = false;
-
         const { zIndices } = this.state;
         // remove wherever the element is
         zIndices.splice(zIndices.indexOf(i), 1);