fix(#zimic): exit process after stopping the interceptor server through CLI #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diego-aquino
deleted the
@diego-aquino/force-process-exit-after-finished-interceptor-server-cli
branch
diego-aquino
added a commit
that referenced
this pull request
Jul 14, 2024
…gh CLI (#295) ### Fixes - [#zimic] Added a call to `process.exit(0)` after an interceptor server is stopped in ephemeral mode. This is to make sure that the process does not hangs, even though the server has been stopped. It is not clear to me how hanging happens, but it rarely does in the tests of `zimic-test-client`. ### Documentation - [#zimic] Included `process.exit(0)` to the documentation about interceptor server programmatic usage. - [#zimic] Fixed a code snippet still using `runCommand`, which is no longer available in >=v0.8.
Released in v0.8.1 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
process.exit(0)after an interceptor server is stopped in ephemeral mode. This is to make sure that the process does not hangs, even though the server has been stopped. It is not clear to me how hanging happens, but it rarely does in the tests ofzimic-test-client.Documentation
process.exit(0)to the documentation about interceptor server programmatic usage.runCommand, which is no longer available in >=v0.8.