Monetary Exchange #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I refactor my code to be more consistent, and remove duplicate code. I comment out the peer_test methods because I plan to refactor them.
- Added ledger integration to the handle_accept_exchange() method of the Peer class - Added a get_artwork_by_id() method to the Inventory class Next steps: Add peer tests.
- Changed naming of modules and methods to fit the exchange type, which is divided into "sale" and "trade". - Modified exchange ```Peer``` methods to fit "sale" on top of "trade" - Tested all ```Peer``` class methods.
zimmermatt
requested changes
May 5, 2024
- Rework ```Peer``` exchange method tests to account for failure cases
and remove redundancy
- For example, a method may have an additional functionality for
only one ```exchange_type```, so I test the ```exchange_type```
with additional funcitonality.
- Rework ```Peer``` exchange methods
- Remove redundant code between ```handle_exchange_response``` and
```handle_response_deadline```
- Change naming of logs to be concise and sensical
- Rework additional classes
- Convert ```artwork_id``` argument to ```artwork``` in
```OfferAnnouncement``` and ```OfferResponse```
- Change naming of arguments to be more sensical
- Added Ledger integration to the `handle_accept_exchnage` method
of the `Peer` class.
- The `handle_accept_exchange` method now adds the exchanger
to the ledger.
- Modified Ledger class
- `add_owner()` method now takes in the peer's public key instead
of the peer object.
zimmermatt
pushed a commit
that referenced
this pull request
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Peerclass methods to work for "sale" and "trade"Peermethods.