Make line length consistent across code formatters #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've been using Ruff for formatting, which defaults to 88 characters for its max line length. So we don't end up with a lot of whitespace changes for existing files and contention between Ruff and Editor Config, this commit set the line length for Editor Config to match Ruff's default. In addition, the PEP 8 standard of 80 characters is too restrictive and does not make much sense given modern displays. It probably reflects what made sense in 2001 when it was adopted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been using Ruff for formatting, which defaults to 88 characters for its max line length. So we don't end up with a lot of whitespace changes for existing files and contention between Ruff and Editor Config, this commit set the line length for Editor Config to match Ruff's default.
In addition, the PEP 8 standard of 80 characters is too restrictive and does not make much sense given modern displays. It probably reflects what made sense in 2001 when it was adopted.