-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔨🐞 Invitations are not being Delivered (May 23rd 2023 12PM PT to May 26th 2023 8PM PT) #1515
Closed
4 tasks done
Tracked by
#1514
Labels
Comments
zspencer
added a commit
that referenced
this issue
May 27, 2023
- #1515 Turns out, when I had suggested we drop the Convene bits from the email I did not think about what that would mean from the email address perspective. While I don't have a Github issue yet for Space's being able to send email from their domain; I think that would be a good thing for us to support at some point so our clients branding stays front and center and we stay in the background. In the meantime, since it's coming from a convene domain, we should probably include the convene support name as well.
zspencer
added a commit
that referenced
this issue
May 27, 2023
- #1515 Turns out, when I had suggested we drop the Convene bits from the email I did not think about what that would mean from the email address perspective. While I don't have a Github issue yet for Space's being able to send email from their domain; I think that would be a good thing for us to support at some point so our clients branding stays front and center and we stay in the background. In the meantime, since it's coming from a convene domain, we should probably include the convene support name as well.
zspencer
added a commit
that referenced
this issue
May 27, 2023
…Email Address (#1516) `Invitations`: Include Neighborhood Support Email as Invitation - #1515 Turns out, when I had suggested we drop the Convene bits from the email I did not think about what that would mean from the email address perspective. While I don't have a Github issue yet for Space's being able to send email from their domain; I think that would be a good thing for us to support at some point so our clients branding stays front and center and we stay in the background. In the meantime, since it's coming from a convene domain, we should probably include the convene support name as well.
PR is in, I'm going to let the deploy go out and then send myself a new invitation to confirm it's fixed. |
Deploy is out, beginning testing. |
I am going to close this out now and split the task to figure out how to make emails be very sad if they are malformed to it's own issue. |
This was referenced May 27, 2023
zspencer
changed the title
🐞 Invitations are not being Delivered
🔨🐞 Invitations are not being Delivered
May 27, 2023
zspencer
changed the title
🔨🐞 Invitations are not being Delivered
🔨🐞 Invitations are not being Delivered (May 23rd 2023 12PM PT to May 26th 2023 8PM PT)
May 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Space
:Invitations
#1514Members
:Invitation
email conveys whichSpace
andPerson
it came from #1483; as prompted by 🌸✨Members
:Invitation
email should convey whichSpace
andPerson
it came from #1481.As of noon, May 23rd 2023 invitation emails have been down.
We noticed the problem on May 26th around 7:00pm.
I've linked the Sentry issue and am beginning remediation.
Neighborhood
: Investigate why emails without an email in the from field didn't throw exceptions #1518The text was updated successfully, but these errors were encountered: