🐞 Space: Fix broken forms and links when on a BYODomain
#1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We probably want to figure out a better strategy for how we test the BYO domains feature; perhaps there's a way to do it with the end-to-end tests so that they run against a BYO-domained Space and a non-BYO domained space in different github actions? I don't know 🤷 #74
zspencer
changed the title
Space: Fix broken forms and links when on a BYODomain
zspencer
changed the title
Space: Fix broken forms and links when on a BYODomainSpace: Fix broken forms and links when on a BYODomain
zspencer
added a commit
that referenced
this pull request
Mar 3, 2023
- Extracted from htps://github.com//pull/1083 This is mostly for consistency and to start to close out a piece of work I started a while back but never finished.
zspencer
added a commit
that referenced
this pull request
Mar 3, 2023
- Extracted from htps://github.com//pull/1083 This is mostly for consistency and to start to close out a piece of work I started a while back but never finished.
This was referenced Mar 4, 2023
zspencer
added a commit
that referenced
this pull request
Mar 4, 2023
zspencer
added a commit
that referenced
this pull request
Mar 4, 2023
🧹 `Utility`: Use `#location` in forms - Extracted from htps://github.com//pull/1083 This is mostly for consistency and to start to close out a piece of work I started a while back but never finished.
|
And with that, I think all the changes are gone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We probably want to figure out a better strategy for how we test the BYO domains feature; perhaps there's a way to do it with the end-to-end tests so that they run against a BYO-domained Space and a non-BYO domained space in different github actions? I don't know 🤷
#74