Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marketplace: Distributor may set Marketplace#delivery_window #1218

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Marketplace: Distributor may set Marketplace#delivery_window #1218

merged 1 commit into from
Mar 16, 2023

Conversation

zspencer
Copy link
Member

Added a Marketplace#delivery_window attribute, which is a plain-old-string for now. It's going to quickly become insufficient, because we may need to do date and time crap at one point.

But "quickly" could mean "months from now!" sooooooo.

- #1185

Added a `Marketplace#delivery_window` attribute, which is a
plain-old-string for now. It's going to quickly become insufficient,
because we *may* need to do date and time crap at one point.

But "quickly" could mean "months from now!" sooooooo.

Co-authored-by: Ana Ulin <anaulin@users.noreply.github.com>
Co-authored-by: Dalton Pruitt <daltonrpruitt@users.noreply.github.com>
Co-authored-by: Kelly Hong <KellyAH@users.noreply.github.com>
Co-authored-by: Ross Chapman <rosschapman@users.noreply.github.com>
Copy link
Contributor

@KellyAH KellyAH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zspencer zspencer merged commit ef84206 into zinc-collective:main Mar 16, 2023
@zspencer zspencer deleted the marketplace/delivery-windows branch March 16, 2023 01:20
@zspencer zspencer added ✨ feature Reduces Client's Burden or Grants them Benefits 🥔 Satisfices It's good enough to use, but not particularly great labels Apr 8, 2023
@zspencer zspencer added this to the 1.0 - Andromeda milestone May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature Reduces Client's Burden or Grants them Benefits 🥔 Satisfices It's good enough to use, but not particularly great
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants