🥗🥔🧹✨ Marketplace: Test how we communicate DeliveryExpectations
#1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- #1185 As we were beginning to implement how we communicate the different expectations based on delivery area, we noticed there were not many tests on the current behavior; and that chunk of behavior had many many many permutations that were meaningful. So we took some time to pull out a `DeliveryExpectationsComponent` that can take care of handling those permutations, and start to test them. There is some minor wording improvements included here, specifically because we noticed things didn't always make a ton of sense as we added those tests; so it *does* include a bit of behavior changes. Co-authored-by: Neer Malathapa <nirmalathapa@users.noreply.github.com> Co-authored-by: Dicko Sow <s12dsow@users.noreply.github.com>
zspencer
added
✨ feature
zspencer
changed the title
Marketplace: Test how we communicate delivery expectationsMarketplace: Test how we communicate DeliveryExpectations
anaulin
approved these changes
Apr 16, 2023
zspencer
deleted the
marketplace/delivery-area/cart-shows-appropriate-delivery-expectations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marketplace:DeliveryConstraints #1185As we were beginning to implement how we communicate the different expectations based on delivery area, we noticed there were not many tests on the current behavior; and that chunk of behavior had many many many permutations that were meaningful.
So we took some time to pull out a
DeliveryExpectationsComponentthat can take care of handling those permutations, and start to test them.There is some minor wording improvements included here, specifically because we noticed things didn't always make a ton of sense as we added those tests; so it does include a bit of behavior changes.