🧹🛠️ Marketplace: return only Marketplaces!
#1423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zspencer
force-pushed
the
marketplace/filter-down-to-just-marketplaces
branch
from
f1eb642
to
d2ae68b
Compare
- #831 - #709 There's something appealing about switching to Rails' built in `Single Table Inheritance` for `Furniture`, rather than our flyweight registry; but I also know that STI can be a bit of a smell... Anyway, now when you call `Marketplace.all` and get *only* `Marketplace`s. Maybe someday we'll pull this up in to the `Furniture` classes responsibilities so we don't have to do it on every single piece of Furniture...
zspencer
changed the title
Marketplace: return only Marketplaces!Marketplace: return only Marketplaces!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gizmo:Marketplace#831Gizmos#709There's something appealing about switching to Rails' built in
Single Table InheritanceforFurniture, rather than our flyweight registry; but I also know that STI can be a bit of a smell...Anyway, now when you call
Marketplace.alland get onlyMarketplaces. Maybe someday we'll pull this up in to theFurnitureclasses responsibilities so we don't have to do it on every single piece of Furniture...