213 forces uncertainty selection broken #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PythonFZ
requested changes
Oct 23, 2023
|
I included all your comments. I also had to finde some abstractions because there where to many if statements in the function. |
PythonFZ
reviewed
Oct 25, 2023
PythonFZ
requested changes
Oct 25, 2023
PythonFZ
approved these changes
Oct 25, 2023
PythonFZ
added
the
merge-after-next-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the forces uncertainty selection.
The
ThresholdSelectionnow gets a new keyworddim_reductionwhere you can choose how you want do reduce the dimensionallety (meanormax) and along which axes you want to reduce the uncertainty. With that it is also more flexible for future uncertainty measures.