Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add AddDataH5MD #29

Merged
merged 2 commits into from
Mar 27, 2023
Merged

add AddDataH5MD #29

merged 2 commits into from
Mar 27, 2023

Conversation

PythonFZ
Copy link
Member

@PythonFZ PythonFZ commented Mar 27, 2023 •
edited
Loading

Provide a Node to read directly from *.h5 files in H5MD standard.

@PythonFZ PythonFZ marked this pull request as ready for review March 27, 2023 10:50
@PythonFZ PythonFZ requested a review from M-R-Schaefer March 27, 2023 11:13
M-R-Schaefer
M-R-Schaefer approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@M-R-Schaefer M-R-Schaefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@PythonFZ PythonFZ merged commit 0deb04f into main Mar 27, 2023
@PythonFZ PythonFZ deleted the add_data_h5md branch March 27, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M-R-Schaefer M-R-Schaefer M-R-Schaefer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PythonFZ @M-R-Schaefer