fix zn.nodes(None) (#541)

zincware · Mar 21, 2023 · 6226c73 · 6226c73
1 parent 4d84471
commit 6226c73
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/tests/integration/test_none_values.py b/tests/integration/test_none_values.py
@@ -66,11 +66,17 @@ def test_from_dvc_deps(proj_path, eager):
 
 class EmptyNodesNode(zntrack.Node):
     nodes = zntrack.zn.nodes(None)
+    outs = zntrack.zn.outs()
 
     def run(self):
-        pass
+        self.outs = 42
 
 
-def test_EmptyNode(proj_path):
+@pytest.mark.parametrize("eager", [True, False])
+def test_EmptyNode(proj_path, eager):
     with zntrack.Project() as project:
         node = EmptyNodesNode()
+    project.run(eager=eager)
+    if not eager:
+        node.load()
+    assert node.outs == 42
diff --git a/zntrack/fields/zn/__init__.py b/zntrack/fields/zn/__init__.py
@@ -369,6 +369,8 @@ def __set__(self, instance, value):
     def get_node_names(self, instance) -> list:
         """Get the name of the other Node."""
         value = instance.__dict__[self.name]
+        if value is None:  # the zn.nodes(None) case
+            return []
         if isinstance(value, (list, tuple)):
             return [f"{instance.name}_{self.name}_{idx}" for idx in range(len(value))]
         return [f"{instance.name}_{self.name}"]