-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
named nodes #129
named nodes #129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It all looks good I just had a question about one method. We should also run the license header updater on this soon.
Can you make the license header an issue? Which files are missing? |
None files are missing all of the headers are just the old ones. |
Had to make a new PR, because of rebasing conflicts on the other one.
TODOs
Example
A Node can now be named, this allows using the same Node in different dependencies or using the same Node multiple times with slightly different parameters. E.g. this can be useful for adding multiple files. The file adding syntax does not change, and all Nodes are required to be on the same graph.