-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add classes for Inheritance #134
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # zntrack/utils/type_hints.py
I think the idea is really nice. I am bit confused or I guess unsure of the mix with both named nodes and the idea of attaching methods. Can you run through what the over all idea is? |
SamTov
approved these changes
Nov 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great changes to the project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #133
TODOs
Base
andChild
Child
to a dataclass containing all possible dvc/zn options and also include all of them in theBase
Base.methods
some sort of abstractmethod?- [ ] tests (no idea how to test them yet!)moved to Add Tests for #134 #141Maybe rename .method to something that can not be mixed up with class methods?
Example
This would - remove the inheritance for the parent, naming conventions, abstract method of methods, multiple methods and also one does not keep a dictionary up-to-date because it is not required anymore. It currently requires setting e.g. the outs/deps/... from the child method manually.
using importlib as follows