Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use znjson instead of built in serializer #158

Merged
merged 2 commits into from
Dec 9, 2021
Merged

Use znjson instead of built in serializer #158

merged 2 commits into from
Dec 9, 2021

Conversation

PythonFZ
Copy link
Member

@PythonFZ PythonFZ commented Dec 6, 2021 •
edited
Loading

Remove the ZnTrack internal serializer to use the pip install znjson package.
see https://github.com/zincware/ZnJSON

This allows better testing of the serializing package and a broader framework.

@PythonFZ PythonFZ requested a review from SamTov December 6, 2021 08:07
@PythonFZ PythonFZ changed the title Use znconv instead of built in serializer Use znjson instead of built in serializer Dec 6, 2021
@PythonFZ PythonFZ linked an issue Dec 7, 2021 that may be closed by this pull request
Exend JSONEncoder instead of serializing the data #152
Closed
SamTov
SamTov approved these changes Dec 9, 2021
View reviewed changes
Copy link
Member

@SamTov SamTov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice.

@PythonFZ PythonFZ merged commit 74b1597 into main Dec 9, 2021
@PythonFZ PythonFZ deleted the add_znconv branch December 9, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamTov SamTov SamTov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exend JSONEncoder instead of serializing the data
2 participants
@PythonFZ @SamTov