Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change serializer #231

Merged
merged 8 commits into from
Feb 16, 2022
Merged

change serializer #231

merged 8 commits into from
Feb 16, 2022

Conversation

PythonFZ
Copy link
Member

@PythonFZ PythonFZ commented Feb 14, 2022

This PR is best described by the new params.yaml / znrack.json split, now including the _cls as a parameter.

def zntrack_params_dict() -> (dict, dict):
zntrack_dict = {
"SingleNodeNoParams": {
"data_class": {"_type": "zn.method", "value": {"module": "test_zn_methods"}}
}
}
params_dict = {
"SingleNodeNoParams": {
"data_class": {"_cls": "ExampleMethod", "param1": 1, "param2": 2}
}
}

vs. the old one
zntrack_dict = {
"SingleNodeNoParams": {
"data_class": {
"_type": "zn.method",
"value": {"cls": "ExampleMethod", "module": "test_zn_methods"},
}
}
}
params_dict = {"SingleNodeNoParams": {"data_class": {"param1": 1, "param2": 2}}}

@PythonFZ PythonFZ linked an issue Feb 14, 2022 that may be closed by this pull request
@PythonFZ PythonFZ marked this pull request as ready for review February 15, 2022 15:27
@PythonFZ PythonFZ requested a review from SamTov February 15, 2022 15:41
@PythonFZ PythonFZ merged commit 802bb60 into main Feb 16, 2022
@PythonFZ PythonFZ deleted the fix_serializer branch February 16, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order in zn.Method()
1 participant