-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Cleanup + Docs + Bugfixes #232
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PythonFZ
force-pushed
the
lazy_loader
branch
from
February 14, 2022 16:58
bef017c
to
3a644f3
Compare
PythonFZ
force-pushed
the
lazy_loader
branch
from
February 15, 2022 15:41
ef277cc
to
0ce316d
Compare
There were two load methods: Node.load() and ZnTrackOption.load() and the ZnTrackOption one is now renamed.
PythonFZ
force-pushed
the
lazy_loader
branch
from
February 15, 2022 16:19
0ce316d
to
b095474
Compare
# Conflicts: # tests/unit_tests/zn/test_zn_options.py # zntrack/zn/__init__.py # zntrack/zn/method.py # zntrack/zn/split_option.py
PythonFZ
force-pushed
the
lazy_loader
branch
from
February 17, 2022 11:10
dc479b4
to
f75b801
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR started out as the lazy loading implementation but ended up being a code cleanup first to prepare for lazy loading later.
File
dataclassMetadata
dataclass