-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a lazy-loading mechanic #236
Conversation
Codecov Report
@@ Coverage Diff @@
## main #236 +/- ##
==========================================
- Coverage 69.44% 68.62% -0.82%
==========================================
Files 23 23
Lines 985 1023 +38
Branches 183 195 +12
==========================================
+ Hits 684 702 +18
- Misses 284 298 +14
- Partials 17 23 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
# Conflicts: # zntrack/core/zntrackoption.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a really nice addition. I looked over the notebooks and maybe some more comments to it for additional support. On an unrelated topic, is there much one can do about the excess stdout from DVC?
If you have nested Node structures you don't want to load everything but only the files you really need. With
lazy
the file will only be read when accessed via__get__
and therefore the memory will not be filled with unneccessary data.Explanation of changes can best be found at https://github.com/zincware/ZnTrack/blob/add_lazy/examples/docs/09_lazy.ipynb
TODOs
config.lazy
does anything