Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop converting jupyter to python after class definition is found #238

Merged
merged 4 commits into from
Feb 18, 2022

Conversation

PythonFZ
Copy link
Member

@PythonFZ PythonFZ commented Feb 18, 2022

Currently the full notebook is converted into a *.py file.
With this change you can add # zntrack: break to stop converting the Notebook into a *.py file, if the Node that the conversion triggered was already found.

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #238 (b42c1af) into main (2622e8d) will decrease coverage by 0.42%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
- Coverage   69.86%   69.44%   -0.43%     
==========================================
  Files          23       23              
  Lines         979      985       +6     
  Branches      180      183       +3     
==========================================
  Hits          684      684              
- Misses        278      284       +6     
  Partials       17       17              
Flag Coverage Δ
unittests 69.44% <0.00%> (-0.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
zntrack/core/jupyter.py 17.94% <0.00%> (-3.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2622e8d...b42c1af. Read the comment docs.

@PythonFZ PythonFZ merged commit 86fc2f4 into main Feb 18, 2022
@PythonFZ PythonFZ deleted the jupyter_stop_early branch February 18, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant