Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tracked value tracked #253

Merged
merged 7 commits into from
Mar 5, 2022
Merged

Remove tracked value tracked #253

merged 7 commits into from
Mar 5, 2022

Conversation

PythonFZ
Copy link
Member

@PythonFZ PythonFZ commented Mar 5, 2022

  • rename zntrack_type to zn_type to fit utils.ZnTypes
  • automatically selected dvc_option based on class name, if None is provided
  • introdue utils.DVCOptions enum
  • add VALUE_DVC_TRACKED and FILE_DVC_TRACKED

@codecov
Copy link

codecov bot commented Mar 5, 2022

Codecov Report

Merging #253 (ea260b9) into main (64fb149) will increase coverage by 0.40%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
+ Coverage   70.86%   71.26%   +0.40%     
==========================================
  Files          23       24       +1     
  Lines        1064     1051      -13     
  Branches      200      201       +1     
==========================================
- Hits          754      749       -5     
+ Misses        289      281       -8     
  Partials       21       21              
Flag Coverage Δ
unittests 71.26% <93.33%> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
zntrack/core/dvcgraph.py 71.91% <55.55%> (ø)
zntrack/core/base.py 85.89% <66.66%> (+2.14%) ⬆️
zntrack/core/zntrackoption.py 83.33% <100.00%> (ø)
zntrack/dvc/__init__.py 97.61% <100.00%> (-0.72%) ⬇️
zntrack/utils/__init__.py 100.00% <100.00%> (+14.28%) ⬆️
zntrack/utils/config.py 100.00% <100.00%> (ø)
zntrack/utils/structs.py 100.00% <100.00%> (ø)
zntrack/zn/__init__.py 82.35% <100.00%> (-2.65%) ⬇️
zntrack/zn/method.py 70.83% <100.00%> (ø)
zntrack/zn/plots.py 68.00% <100.00%> (-1.24%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64fb149...ea260b9. Read the comment docs.

PythonFZ added 3 commits March 5, 2022 19:12
- add test for LazyOption init
- move ZnTypes and DVCOptions to structs module
@PythonFZ PythonFZ merged commit 1f485b8 into main Mar 5, 2022
@PythonFZ PythonFZ deleted the remove_tracked_value_tracked branch March 5, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

value_tracked / tracked are exclusives and should be replaced by a single bool
1 participant