Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Inheritance Issue #267

Merged
merged 22 commits into from
Mar 30, 2022
Merged

Fix Inheritance Issue #267

merged 22 commits into from
Mar 30, 2022

Conversation

PythonFZ
Copy link
Member

@PythonFZ PythonFZ commented Mar 25, 2022

ToDo

  • add tests to show the issue
  • fix the issue
  • fix issue with calling two Child Nodes after each other and loading the wrong results (see PassingClasses.ipynb) (This is partially fixed and mentioned in the documentation)
  • update documentation

@PythonFZ PythonFZ linked an issue Mar 25, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #267 (d0f83c3) into main (b955e06) will decrease coverage by 0.12%.
The diff coverage is 84.12%.

@@            Coverage Diff             @@
##             main     #267      +/-   ##
==========================================
- Coverage   72.36%   72.23%   -0.13%     
==========================================
  Files          26       26              
  Lines        1118     1149      +31     
  Branches      216      226      +10     
==========================================
+ Hits          809      830      +21     
- Misses        286      293       +7     
- Partials       23       26       +3     
Flag Coverage Δ
unittests 72.23% <84.12%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
zntrack/zn/__init__.py 77.77% <0.00%> (-4.58%) ⬇️
zntrack/utils/file_io.py 84.31% <71.42%> (-2.05%) ⬇️
zntrack/core/dvcgraph.py 68.91% <77.77%> (-1.75%) ⬇️
zntrack/descriptor/__init__.py 95.55% <85.71%> (-4.45%) ⬇️
zntrack/core/base.py 90.00% <91.66%> (-0.91%) ⬇️
zntrack/core/zntrackoption.py 86.36% <100.00%> (ø)
zntrack/dvc/__init__.py 97.72% <100.00%> (+0.10%) ⬆️
zntrack/utils/utils.py 72.81% <100.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b955e06...d0f83c3. Read the comment docs.

@PythonFZ PythonFZ force-pushed the 266-can-not-inherit-from-node branch from 55a33b6 to e3322d6 Compare March 25, 2022 20:17
@PythonFZ PythonFZ marked this pull request as ready for review March 26, 2022 17:48
@PythonFZ PythonFZ merged commit 656b9cf into main Mar 30, 2022
@PythonFZ PythonFZ deleted the 266-can-not-inherit-from-node branch March 30, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not inherit from Node
1 participant