Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: change plots filename #273

Merged
merged 2 commits into from
Apr 12, 2022
Merged

bugfix: change plots filename #273

merged 2 commits into from
Apr 12, 2022

Conversation

PythonFZ
Copy link
Member

@PythonFZ PythonFZ commented Apr 12, 2022

When multiple zn.plots where defined they would overwrite each other. Using different filenames prohibits this.

TODOs

  • tests

When multiple zn.plots where defined they would overwrite each other. Using different filenames prohibits this.
@PythonFZ PythonFZ marked this pull request as ready for review April 12, 2022 12:46
@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #273 (09846d6) into main (d836039) will increase coverage by 0.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #273      +/-   ##
==========================================
+ Coverage   72.06%   72.23%   +0.17%     
==========================================
  Files          26       26              
  Lines        1149     1149              
  Branches      226      226              
==========================================
+ Hits          828      830       +2     
+ Misses        295      293       -2     
  Partials       26       26              
Flag Coverage Δ
unittests 72.23% <100.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
zntrack/zn/plots.py 68.00% <100.00%> (ø)
zntrack/utils/serializer.py 78.87% <0.00%> (+2.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d836039...09846d6. Read the comment docs.

@PythonFZ PythonFZ merged commit d6a44dd into main Apr 12, 2022
@PythonFZ PythonFZ deleted the fix_multiple_zn_plots branch April 12, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant