Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change dvc.params to work with files #276

Merged
merged 3 commits into from
Apr 22, 2022
Merged

change dvc.params to work with files #276

merged 3 commits into from
Apr 22, 2022

Conversation

PythonFZ
Copy link
Member

@PythonFZ PythonFZ commented Apr 22, 2022

  • remove old functionality from dvc.params to map zn.params
  • use dvc.params to add files as parameters.

TODO

  • Update documentation
  • tests

* remove old functionality from `dvc.params` to map `zn.params`
* use `dvc.params` to add files as parameters.
@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #276 (98fa1f3) into main (4864775) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #276      +/-   ##
==========================================
- Coverage   71.28%   71.24%   -0.04%     
==========================================
  Files          27       27              
  Lines        1191     1193       +2     
  Branches      237      238       +1     
==========================================
+ Hits          849      850       +1     
- Misses        316      317       +1     
  Partials       26       26              
Flag Coverage Δ
unittests 71.24% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
zntrack/core/jupyter.py 23.80% <ø> (ø)
zntrack/core/dvcgraph.py 68.35% <100.00%> (+1.03%) ⬆️
zntrack/dvc/__init__.py 100.00% <100.00%> (+2.22%) ⬆️
zntrack/utils/serializer.py 76.05% <0.00%> (-2.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4864775...98fa1f3. Read the comment docs.

@PythonFZ PythonFZ marked this pull request as ready for review April 22, 2022 15:35
@PythonFZ PythonFZ changed the title make dvc.params compatible with files change dvc.params to work with files Apr 22, 2022
@PythonFZ PythonFZ merged commit fd67c18 into main Apr 22, 2022
@PythonFZ PythonFZ deleted the fix_dvc_params branch April 22, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant