Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hash issue with znjson serialization #305

Merged
merged 1 commit into from
May 23, 2022
Merged

fix hash issue with znjson serialization #305

merged 1 commit into from
May 23, 2022

Conversation

PythonFZ
Copy link
Member

The zn.Hash did not use znjson.ZnEncoder which could lead to issues, e.g. if a parameter used a dataclass.

@PythonFZ PythonFZ requested a review from laigner May 23, 2022 07:54
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #305 (2ddfc91) into main (7ad2c49) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #305      +/-   ##
==========================================
+ Coverage   71.49%   71.51%   +0.02%     
==========================================
  Files          29       29              
  Lines        1319     1320       +1     
  Branches      262      262              
==========================================
+ Hits          943      944       +1     
  Misses        346      346              
  Partials       30       30              
Flag Coverage Δ
unittests 71.51% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
zntrack/core/dvcgraph.py 67.87% <100.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ad2c49...2ddfc91. Read the comment docs.

@laigner laigner merged commit c86a05d into main May 23, 2022
@PythonFZ PythonFZ deleted the bugfix_hash branch May 25, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants