Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add use_node_dir to save results in the nodes directory #353

Merged
merged 4 commits into from
Aug 1, 2022

Conversation

PythonFZ
Copy link
Member

@PythonFZ PythonFZ commented Aug 1, 2022

- partially address #226
- allow dvc.<...> to store results in a dedicated node directory
- split __get__
- small bugfix with auto_init and super_init call
@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #353 (b60f308) into main (48cd812) will decrease coverage by 0.39%.
The diff coverage is 98.33%.

@@            Coverage Diff             @@
##             main     #353      +/-   ##
==========================================
- Coverage   96.61%   96.21%   -0.40%     
==========================================
  Files          33       33              
  Lines        1448     1481      +33     
  Branches      597      617      +20     
==========================================
+ Hits         1399     1425      +26     
- Misses         49       56       +7     
Flag Coverage Δ
fulltest 96.21% <98.33%> (+0.01%) ⬆️
unittests 71.02% <70.00%> (-0.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
zntrack/dvc/custom_base.py 96.82% <96.96%> (+0.05%) ⬆️
zntrack/core/zntrackoption.py 95.77% <100.00%> (-0.06%) ⬇️
zntrack/dvc/__init__.py 100.00% <100.00%> (ø)
zntrack/utils/utils.py 91.81% <100.00%> (+0.22%) ⬆️
zntrack/core/jupyter.py 47.61% <0.00%> (-14.29%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@PythonFZ PythonFZ marked this pull request as ready for review August 1, 2022 13:22
@PythonFZ PythonFZ merged commit 96a69b2 into main Aug 1, 2022
@PythonFZ PythonFZ deleted the dvc_use_node_dir branch August 1, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant