Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update automatic __init__ to require non-default kwargs #387

Merged
merged 3 commits into from
Sep 19, 2022

Conversation

PythonFZ
Copy link
Member

No description provided.

The new auto_init requires arguments without defaults to be passed. These tests had to be updated.
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #387 (f075169) into main (6f27a1f) will decrease coverage by 0.26%.
The diff coverage is 95.23%.

@@            Coverage Diff             @@
##             main     #387      +/-   ##
==========================================
- Coverage   96.57%   96.30%   -0.27%     
==========================================
  Files          34       34              
  Lines        1546     1569      +23     
  Branches      650      664      +14     
==========================================
+ Hits         1493     1511      +18     
- Misses         53       58       +5     
Flag Coverage Δ
fulltest 95.92% <95.23%> (-0.27%) ⬇️
unittests 71.65% <71.42%> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
zntrack/utils/utils.py 90.07% <91.66%> (-1.75%) ⬇️
zntrack/core/base.py 99.21% <100.00%> (+0.01%) ⬆️
zntrack/core/zntrackoption.py 93.97% <100.00%> (ø)
zntrack/core/dvcgraph.py 96.22% <0.00%> (-0.48%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@PythonFZ PythonFZ merged commit fd5661b into main Sep 19, 2022
@PythonFZ PythonFZ deleted the 385-default-values-eg-for-znparams branch September 19, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default values e.g. for zn.params Add better Errors for init arguments
1 participant