Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo call cargs change #402

Merged
merged 3 commits into from
Oct 6, 2022
Merged

Undo call cargs change #402

merged 3 commits into from
Oct 6, 2022

Conversation

PythonFZ
Copy link
Member

@PythonFZ PythonFZ commented Oct 6, 2022

For readability use Node.load(name='{self.node_name}' instead of Node['self.node_name']

@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Merging #402 (4db0ed6) into main (1803cb5) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #402   +/-   ##
=======================================
  Coverage   96.45%   96.45%           
=======================================
  Files          33       33           
  Lines        1466     1466           
  Branches      622      531   -91     
=======================================
  Hits         1414     1414           
  Misses         52       52           
Flag Coverage Δ
fulltest 96.04% <100.00%> (ø)
unittests 71.87% <83.33%> (+1.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
zntrack/__init__.py 100.00% <100.00%> (ø)
zntrack/core/base.py 97.37% <100.00%> (ø)
zntrack/utils/serializer.py 96.15% <100.00%> (ø)
zntrack/zn/dependencies.py 95.12% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@PythonFZ PythonFZ marked this pull request as ready for review October 6, 2022 14:43
@PythonFZ PythonFZ merged commit f3b97ff into main Oct 6, 2022
@PythonFZ PythonFZ deleted the undo_call_cargs_change branch October 6, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant