Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking Update Add UUID output to every Node #647

Merged
merged 11 commits into from
Jun 28, 2023

Conversation

PythonFZ
Copy link
Member

@PythonFZ PythonFZ commented Jun 27, 2023

This PR will require an update of all Nodes:

  1. Rewrite the Graph
  2. zntrack run ipsuite.nodes.LangevinThermostat --name <node-name> --uuid-only
  3. dvc commit nodes/<node-name>/uuid

Otherwise, the stage will not load be rerun!

Furthermore, it is no longer possible to have:

zntrack.dvc.outs(zntrack.nwd)

but only

zntrack.dvc.outs(zntrack.nwd/<your file or path>)

@PythonFZ PythonFZ linked an issue Jun 27, 2023 that may be closed by this pull request
@PythonFZ PythonFZ changed the title rename hash to UUID Add UUID output to every Node Jun 27, 2023
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #647 (50a6845) into main (e4479cb) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #647      +/-   ##
==========================================
+ Coverage   89.42%   89.54%   +0.12%     
==========================================
  Files          21       21              
  Lines        1560     1578      +18     
  Branches      601      617      +16     
==========================================
+ Hits         1395     1413      +18     
  Misses        165      165              
Flag Coverage Δ
fulltest 89.54% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
zntrack/cli/__init__.py 85.00% <100.00%> (+1.39%) ⬆️
zntrack/core/node.py 92.51% <100.00%> (+0.16%) ⬆️
zntrack/fields/dvc/__init__.py 88.88% <100.00%> (+0.36%) ⬆️
zntrack/fields/zn/__init__.py 91.35% <100.00%> (+0.44%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@PythonFZ PythonFZ requested a review from M-R-Schaefer June 27, 2023 14:01
@PythonFZ PythonFZ changed the title Add UUID output to every Node [Breaking Update] Add UUID output to every Node Jun 27, 2023
@PythonFZ PythonFZ changed the title [Breaking Update] Add UUID output to every Node Breaking Update Add UUID output to every Node Jun 27, 2023
@PythonFZ
Copy link
Member Author

@PythonFZ PythonFZ merged commit aa92f6c into main Jun 28, 2023
@PythonFZ PythonFZ deleted the 641-should-every-node-write-a-znhash-output branch June 28, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should every Node write a zn.Hash output
2 participants