Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Project(git_only_repo: bool) #677

Merged
merged 9 commits into from
Aug 4, 2023
Merged

Conversation

PythonFZ
Copy link
Member

@PythonFZ PythonFZ commented Jul 28, 2023

This option integrated:

The DVC graph relies on file outputs for connecting stages.
ZnTrack will use a '--outs' for each stage by default.
This will require a DVC remote to be setup.
If a project is not used with a DVC remote and strictly GIT,
this can be set to True and instead '--metrics-no-cache' will be used.
Metrics is used instead of 'outs-no-cache' to keep the DVC run cache.

TODO

  • check if removing metrics still is different from removing an dvc tracked output. Run a command and then interrupt it. Then try checkout.
  • check that the default outs is --metrics-no-cache with ´node-meta.json´

@PythonFZ PythonFZ linked an issue Jul 28, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #677 (c1c4405) into main (47b9e00) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #677      +/-   ##
==========================================
+ Coverage   90.11%   90.13%   +0.02%     
==========================================
  Files          21       21              
  Lines        1649     1653       +4     
  Branches      661      664       +3     
==========================================
+ Hits         1486     1490       +4     
  Misses        163      163              
Flag Coverage Δ
fulltest 90.13% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
zntrack/core/node.py 93.17% <100.00%> (+0.10%) ⬆️
zntrack/fields/field.py 94.36% <100.00%> (ø)
zntrack/fields/zn/__init__.py 91.87% <100.00%> (ø)
zntrack/project/zntrack_project.py 90.94% <100.00%> (+0.03%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@PythonFZ PythonFZ merged commit ac36631 into main Aug 4, 2023
@PythonFZ PythonFZ deleted the 673-make-node-metajson-dvc-outs branch August 4, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make node-meta.json dvc outs
1 participant