Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to update labels once marked #58

Closed
sonalgoyal opened this issue Dec 1, 2021 · 8 comments
Closed

Ability to update labels once marked #58

sonalgoyal opened this issue Dec 1, 2021 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@sonalgoyal
Copy link
Member

Right now there is no way to update labels if a wrong one has been specified. See https://zinggai.slack.com/archives/C02JNH144TB/p1638361934009800

@sonalgoyal
Copy link
Member Author

We need to spec this out.

@sonalgoyal
Copy link
Member Author

sonalgoyal commented Dec 3, 2021

What if we had multiple htmls, one per run html containing the pairs and their labels in that run? The label phase could generate this with the round number and pair information everytime. And then have a master html which will have total stats, and links to marked, unmarked etc

eventually, we will be using this structure to print out data quality reports.

we could then define a new phase - updateLabel which takes in the id/ids of the pairs we want to update

@sonalgoyal sonalgoyal removed their assignment Dec 3, 2021
@sonalgoyal
Copy link
Member Author

Let us make a folder html under model/modelId and have same marked/unmaked. Write html version of the dataframe to this folder after findtrainingData and label phases.

@sonalgoyal
Copy link
Member Author

This html framework will eventually be used for dq, stats, model documentation etc so we have to write it in a generic way

@sonalgoyal
Copy link
Member Author

After discussion with @navinrathore :

  • Separate phase generateTrainingDataDocs which goes over marked and unmarked records and builds out the html. The html contains pagination and search. And separate sections for records - marked (match/non match/cant say) and unmarked
  • Focus on readability of pairs in all cases
  • Write under model/modelId/docs/trainingData.html with subfiles.

@sonalgoyal sonalgoyal added the enhancement New feature or request label Dec 6, 2021
@sonalgoyal
Copy link
Member Author

Have a phase updateLabel which first invokes generateTrainingDataDocs and asks the user to tell which record id to update in a loop. It then updates the labels and generates the docs again

@sonalgoyal
Copy link
Member Author

Have a phase updateLabel which first invokes generateTrainingDataDocs and asks the user to tell which record id to update in a loop. It then updates the labels and generates the docs again

@navinrathore can you please work on this?

@sonalgoyal
Copy link
Member Author

Have a phase updateLabel and asks the user to tell which record id to update in a loop. It then updates the labels and generates the docs again

navinrathore added a commit to navinrathore/zingg-1 that referenced this issue Dec 31, 2021
gitbook-com bot pushed a commit that referenced this issue Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants