Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TrainMatcher & FindAndLabeller calling only super class #636

Closed
vikasgupta78 opened this issue Aug 8, 2023 · 0 comments
Closed

TrainMatcher & FindAndLabeller calling only super class #636

vikasgupta78 opened this issue Aug 8, 2023 · 0 comments

Comments

@vikasgupta78
Copy link
Contributor

vikasgupta78 commented Aug 8, 2023 •
edited
Loading

TrainMatcher & FindAndLabeller calling only super base class
so e.g. any special methods implemented in SparkLabeller or SparkMatcher wouldn't have an effect
@vikasgupta78 vikasgupta78 changed the title TrainMatcher calling only super class TrainMatcher & FindAndLabeller calling only super class Aug 8, 2023
vikasgupta78 added a commit to zinggAI/zingg-vikas that referenced this issue Aug 8, 2023
@vikasgupta78
phase findAndLabel and trainMatch should be calling respective concre…
5bd44b5 
…te implementation classes issue zinggAI#636
@vikasgupta78 vikasgupta78 mentioned this issue Aug 8, 2023
Merged
sonalgoyal added a commit that referenced this issue Aug 8, 2023
@sonalgoyal
Merge pull request #639 from zinggAI/issue636
de53e45 
phase findAndLabel and trainMatch should be calling respective implementations #636
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vikasgupta78