Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inmemorypipe accepts pandas df #376

Merged
merged 2 commits into from
Jul 6, 2022
Merged

Conversation

navinrathore
Copy link
Contributor

inMemoryPipe can be created using either Python DataFrame or Pandas DataFrame

@navinrathore
Copy link
Contributor Author

Pipe.getPipe(self).setDataset(ds)
if (df is not None):
self.setDataset(df)
def setDataset(self, df):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line break should be there between methods in python

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

Copy link
Member

@sonalgoyal sonalgoyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a unit test case

@navinrathore
Copy link
Contributor Author

navinrathore commented Jul 5, 2022

please add a unit test case
Test case shall be taken care of as a separate issue.

@sonalgoyal sonalgoyal merged commit ddd8779 into zinggAI:main Jul 6, 2022
@navinrathore navinrathore deleted the APIPandasInput branch July 28, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants