adding session template #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonalgoyal
reviewed
Aug 30, 2022
| public void process() throws ZinggClientException { | ||
| try { | ||
| LOG.info("Data document generation starts"); | ||
|
|
||
| try { | ||
| data = PipeUtil.read(spark, false, false, args.getData()); | ||
| data = PipeUtilBase.read(session, 0, false, args.getData()); |
There was a problem hiding this comment.
this has to be getPipeUtil() - see trainer etc
There was a problem hiding this comment.
pipeutils already have session info - i don't think we need to pass them. again check existing code
There was a problem hiding this comment.
Yeah sorry I missed that function name there.
sonalgoyal
requested changes
Aug 30, 2022
| @@ -41,7 +44,7 @@ protected void createModelDocument() throws ZinggClientException { | |||
| LOG.info("Model document generation starts"); | |||
|
|
|||
| try { | |||
| markedRecords = PipeUtil.read(spark, false, false, PipeUtil.getTrainingDataMarkedPipe(args)); | |||
| markedRecords = PipeUtilBase.read(session, 0, false, PipeUtilBase.getTrainingDataMarkedPipe(args)); | |||
| @@ -20,6 +20,9 @@ public ZFrame<D, R, C> readInternal(boolean addLineNo, | |||
| public ZFrame<D, R, C> read(boolean addLineNo, int numPartitions, | |||
| boolean addSource, Pipe... pipes); | |||
|
|
|||
| public ZFrame<D, R, C> read(S session, int numPartitions, | |||
There was a problem hiding this comment.
this is not needed...we are creating concrete classes which have the session
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For documenter package